Save reading progress for pdfs for each page #3349

carif · 2022-01-18T15:57:33Z

Changes
This removes the 10s interval between saving and instead saves the
reading progress for pdf files every time.

As a side effect, the pdf will appear in the "Continue Watching" section
of Jellyfin. Before this commit, there was no indication that someone
started reading the pdf book.

Issues
Potentially related to #2582, but for pdfs only

dmitrylyzo

To update the resume button after stopping, do the same as #3034: stopped event, destroy function and streamInfo.item.

As for the Watched state, it requires changes on the server side. It currently doesn't extract the page count (RunTimeTicks is TimeSpan.TicksPerSecond: 10000000), and need to update UserDataManager.UpdatePlayState method.

src/plugins/pdfPlayer/plugin.js

dmitrylyzo · 2022-01-19T21:27:30Z

Looks good. Could you squash the commits?

carif · 2022-01-19T21:30:53Z

To update the resume button after stopping, do the same as #3034: stopped event, destroy function and streamInfo.item.

As I've noticed that the bookPlayer is missing those calls, too, I just created PR #3350 to solve it there.

Looks good. Could you squash the commits?

Sure.

This removes the 10s interval between saving and instead saves the reading progress for pdf files every time. As a side effect, the pdf will appear in the "Continue Watching" section of Jellyfin. Before this commit, there was no indication that someone started reading the pdf book. Update the resume button after stopping for the pdf player.