Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper styling to DlnaProfile and ScheduledTask pages #353

Merged
merged 10 commits into from Jun 13, 2019
Merged

Add proper styling to DlnaProfile and ScheduledTask pages #353

merged 10 commits into from Jun 13, 2019

Conversation

grafixeyehero
Copy link
Contributor

Before
Screenshot_2019-06-01 Jellyfin(1)

After
Screenshot_2019-06-01 Jellyfin

DrPandemic
DrPandemic reviewed Jun 2, 2019
View reviewed changes
Copy link
Contributor

@DrPandemic DrPandemic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change, but it seems broken on my computer. I don't get the same rendering on firefox and chrome

Firefox
image

Chrome
image

Also, the button colors seem broken
image

src/components/dialogHelper/dialoghelper.css Outdated
@@ -139,8 +139,8 @@
}

.dialog-small {
width: 60%;
height: 80%;
width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems a little bit weird here, .dialog-small becomes bigger than .dialog-medium. Maybe you should use another class or rename this one?

@DrPandemic
Copy link
Contributor

This page is already weird with all the bullet points, but disregarding that, I think 1 is more readable.

@grafixeyehero
Copy link
Contributor Author

@DrPandemic way u don't get the same rendering on firefox and chrome. b/c on firefox the emby-button inject button-inline class for this i will open a new PR that fix for both. And for the bullet points i will remove it only it appere on the title

@grafixeyehero grafixeyehero changed the title Improveing dlnaprofile layout page Improveing dlnaprofile & scheduledtask layout page Jun 5, 2019
DrPandemic
DrPandemic approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@DrPandemic DrPandemic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the button-link-inline this looks good!

@grafixeyehero
Copy link
Contributor Author

Except for the button-link-inline this looks good!

See PR #356 Fix some style

@dkanada dkanada changed the title Improveing dlnaprofile & scheduledtask layout page Add proper styling to DlnaProfile and ScheduledTask pages Jun 10, 2019
dkanada
dkanada approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@dkanada dkanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I can't believe DlnaProfile never used the style used everywhere else in the frontend.

@anthonylavado anthonylavado merged commit dcd4a76 into jellyfin:master Jun 13, 2019
@grafixeyehero grafixeyehero deleted the dlnaprofile branch June 14, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrPandemic DrPandemic DrPandemic approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grafixeyehero @DrPandemic @dkanada @anthonylavado