Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks to the server settings #360

Merged
merged 8 commits into from Jun 18, 2019
Merged

Small tweaks to the server settings #360

merged 8 commits into from Jun 18, 2019

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Jun 10, 2019

No description provided.

@dkanada
Copy link
Member Author

dkanada commented Jun 11, 2019

I also added the new player check implemented by @vitorsemeano in #334 to avoid the four merge commits in that pull request.

DrPandemic
DrPandemic reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@DrPandemic DrPandemic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for my comment, it seems to work

src/controllers/librarydisplay.js Outdated Show resolved Hide resolved
DrPandemic
DrPandemic approved these changes Jun 15, 2019
View reviewed changes
Copy link
Contributor

@DrPandemic DrPandemic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works on FF

joshuaboniface
joshuaboniface approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joshuaboniface joshuaboniface merged commit 4a3bf18 into jellyfin:master Jun 18, 2019
@dkanada dkanada deleted the metadata branch June 19, 2019 10:16
@dkanada dkanada mentioned this pull request Jun 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrPandemic DrPandemic DrPandemic approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dkanada @DrPandemic @joshuaboniface @vitorsemeano