Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable blurred footer in chrome #406

Merged
merged 2 commits into from Aug 10, 2019
Merged

Enable blurred footer in chrome #406

merged 2 commits into from Aug 10, 2019

Conversation

Nickbert7
Copy link
Contributor

Enables blurred footer also in chrome

Changes
Displays the now playing bar blurred in chrome as in other browsers

Before
image

After
image

@dkanada
Copy link
Member

dkanada commented Aug 8, 2019

It looks like the color is off in the second photo. I'd rather not merge this until we can figure out why, don't want to break themes.

@Nickbert7
Copy link
Contributor Author

Nickbert7 commented Aug 8, 2019

My intention was just to remove the special handling for chrome... but somehow also Firefox has no blur...

Without the change:
Chrome:
image

Firefox:
image

Edge:
image

It would also be fine for me to remove the blur completely, it should just look the same within every browser...

Copy link
Member

@dkanada dkanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because the code changes seem fine. I'll have to look into the CSS eventually though, it looks like the color changes for blurred items.

Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supports (backdrop-filter:blur(10px)) or (-webkit-backdrop-filter:blur(10px)) {

Themes seem to specify this, so if this breaks a theme, it is a problem with the theme, not this change.

Browser compatability isn't good however: https://developer.mozilla.org/en-US/docs/Web/CSS/backdrop-filter#Browser_compatibility

@dkanada dkanada merged commit 5a0da2f into jellyfin:master Aug 10, 2019
@Nickbert7 Nickbert7 deleted the patch-1 branch August 11, 2019 10:08
@anthonylavado anthonylavado added this to Done in Release 10.4.0 Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants