Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix Now playing bar controls #433

Merged
merged 1 commit into from Aug 31, 2019
Merged

Quick fix Now playing bar controls #433

merged 1 commit into from Aug 31, 2019

Conversation

grafixeyehero
Copy link
Contributor

Issues
Now playing bar controls not working #431

@cvium cvium changed the title Qick fix Now playing bar controls Quick fix Now playing bar controls Aug 31, 2019
@cvium
Copy link
Member

cvium commented Aug 31, 2019

Could you elaborate on why you removed the flex-grow?

@grafixeyehero
Copy link
Contributor Author

grafixeyehero commented Aug 31, 2019 •
edited

Could you elaborate on why you removed the flex-grow?
.nowPlayingBarRight take 60% of the screen and .nowPlayingBarInfoContainer take 40% of the screen. when we add a flex-grow in .nowPlayingBarRight It dictates what amount of the available space inside the flex container the item should take the space. so the .nowPlayingBarRight overlap the .nowPlayingBarCenter

@grafixeyehero
Copy link
Contributor Author

Before
21
11
After
31

@dkanada dkanada merged commit 6d34534 into jellyfin:master Aug 31, 2019
@cvium
Copy link
Member

cvium commented Sep 1, 2019

Shouldn't we remove flex-grow from the other two as well?

@grafixeyehero
Copy link
Contributor Author

Shouldn't we remove flex-grow from the other two as well?

which one?

@anthonylavado anthonylavado added this to Done in Release 10.4.0 Sep 2, 2019
@grafixeyehero grafixeyehero deleted the nowPlayingBar branch September 2, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.4.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grafixeyehero @cvium @thornbill @dkanada