Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop progressive transcoding in web client #4385

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Drop progressive transcoding in web client #4385

merged 1 commit into from
Apr 12, 2023

Conversation

nyanmisaka
Copy link
Member

For HEVC playback in Chrome without transcoding:
use compatible audio codecs (e.g. AAC, MP3) and MP4 container or try the Shaka-player fMP4 PR #4041

Changes

  • Drop progressive transcoding in web client

Issues

  • Progressive remuxing/transcoding is not reliable when seeking in browsers.
  • Some changes were made on the server side to raise the priority of progressive remuxing/transcoding but didn't fully test it in various browsers and codecs such as the newly added HEVC hardware decoder in Chrome.

Fixes jellyfin/jellyfin#9196
Fixes jellyfin/jellyfin#9241
Fixes jellyfin/jellyfin#9330

@thornbill thornbill added the bug Something isn't working label Mar 1, 2023
@nyanmisaka
Drop progressive transcoding in web client
62dbf0d 
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@thornbill thornbill added stable backport Backport into the next stable release playback This PR or issue mainly concerns playback labels Apr 12, 2023
@thornbill thornbill added this to Active PRs in Release 10.8.0 via automation Apr 12, 2023
Release 10.8.0 automation moved this from Active PRs to Approved PRs Apr 12, 2023
@thornbill thornbill merged commit c9e5b35 into jellyfin:release-10.8.z Apr 12, 2023
Release 10.8.0 automation moved this from Approved PRs to Completed PRs Apr 12, 2023
@nyanmisaka nyanmisaka deleted the drop-progressive branch April 12, 2023 14:30
This was referenced Apr 12, 2023
Closed
Closed
@MrToast99 MrToast99 mentioned this pull request Apr 24, 2023
Open
1 task
@thornbill thornbill removed the stable backport Backport into the next stable release label Apr 25, 2023
@thornbill thornbill mentioned this pull request Apr 25, 2023
Merged
@dmitrylyzo dmitrylyzo mentioned this pull request Apr 30, 2023
Closed
@DerP4si DerP4si mentioned this pull request May 9, 2023
Closed
1 task
@dmitrylyzo dmitrylyzo mentioned this pull request Nov 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo left review comments

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working playback This PR or issue mainly concerns playback
Projects
No open projects
Release 10.8.0
  
Completed PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanmisaka @thornbill @dmitrylyzo