Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve button style when focused #451

Merged
merged 3 commits into from Sep 14, 2019
Merged

Improve button style when focused #451

merged 3 commits into from Sep 14, 2019

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Sep 7, 2019

No description provided.

src/components/emby-button/emby-button.css Show resolved Hide resolved
src/components/emby-button/emby-button.css Outdated Show resolved Hide resolved
src/components/emby-button/emby-button.js Outdated Show resolved Hide resolved
@JustAMan
Copy link
Contributor

also @dkanada would be very helpful to see a pair of screenshots "before"-"after" to better understand what's going on

@dkanada
Copy link
Member Author

dkanada commented Sep 12, 2019

Tab Button

Icon Button

User Settings

I didn't actually change the styles much. This will just help people search and modify the TV styling much faster. The old method was a unique class for every element and this pull request moves several elements over to a single class that can be chained with the base class to selectively apply styles.

@dkanada dkanada merged commit 09e38ca into jellyfin:master Sep 14, 2019
@dkanada dkanada deleted the style branch September 22, 2019 09:40
@anthonylavado anthonylavado added this to Done in Release 10.4.0 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants