Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xss in api key page #4590

Merged
merged 1 commit into from
May 12, 2023

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented May 12, 2023

Changes
Fixes a XSS vulnerability in the api key page in the admin dashboard when a key is created with a malicious name.

Manual backport of #4589

Issues
Reported by Davide Ferreira, AppSec Analyst at Checkmarx

@thornbill thornbill added bug Something isn't working regression We broke something labels May 12, 2023
@thornbill thornbill requested a review from a team as a code owner May 12, 2023 04:15
@thornbill thornbill added security This PR or issue mainly concerns security and removed regression We broke something labels May 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@thornbill thornbill merged commit a51782b into jellyfin:master May 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security This PR or issue mainly concerns security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants