Fix Duplicate loading animation

[grafixeyehero]

Issues
Duplicate loading animation #199

[JustAMan]

Looks mostly fine, but I am slightly wary of breaking things. Did you test major browsers?

[grafixeyehero]

Wrong btn sorry

[grafixeyehero]

Tested
Chrome 76.0.3809.132
Firefox 70.0b6

[JustAMan]

So you basically flipped the condition? Maybe do just that instead of exchanging two lines, so that the diff is the smallest? (looks like same effect could be achieved just by deleting ! in the if())

[JustAMan]

I hope you have tested this. Awesome fix!

[dkanada]

This adds a duplicate loading animation for firefox on my machine. I definitely want to merge this once we figure out the behavior but this doesn't seem like the right solution.

[grafixeyehero]

This adds a duplicate loading animation for firefox on my machine. I definitely want to merge this once we figure out the behavior but this doesn't seem like the right solution.

the first comment didn't hide on Firefox. i hope this fix switching condition 20c23dc

[dkanada]

Still broken on two out of three browsers I used for testing. One has a Chromium base and the other is Firefox, so they aren't uncommon.

Stale

[grafixeyehero]

@dkanada could you explain me a in which version you test and the problem that you faced. is it the controller or the loading animation

[JustAMan]

Wow, this looks clever! Hope this works.

[dkanada]

I'm sure there was a reason they added the check, but it seems to work fine without the controls so we're probably fine. I tested this on Firefox, Chromium, and a very uncommon browser and it worked on all three.