Change Subtitle Sync slider to go from -300 to 300 #4754
Conversation
mkanilsson
changed the title
mkanilsson
force-pushed
the
webos-subtitle-offset
branch
from
81a42e5
to
aa02a52
Compare
mkanilsson
changed the title
mkanilsson
force-pushed
the
webos-subtitle-offset
branch
from
aa02a52
to
d771a0f
Compare
dmitrylyzo
added
bug
mkanilsson
force-pushed
the
webos-subtitle-offset
branch
from
d771a0f
to
28ab879
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This patch changes the subtitle sync from using a procentage to a 'slider value' that ranges from -300 to 300. The reasons for this is that WebOS doesn't jump in 0.1 increments but instead jumps 1.0 increments in the slider, which results in subtitle sync jumping 0.6s per increment. Using a value from -300 to 300 makes LG WebOS jump 0.1s instead.
There was a problem hiding this comment.
LGTM + it is good to be moved to release-10.8.z branch.
We still can improve it by making slider value to subtitle offset ratio 1:1 (step=".1" min="-30" max="30" value="0").
Possible options:
- Wait Fix slider step #4758
- Or add a call
subtitleSyncSlider.setKeyboardSteps(0.1);after this line.
Given the above, we can rely on the slider: this becomes redundant and this can be simplified.
#4760 will allow to simplify getBubbleHtml and drop getOffsetFromPercentage.
thornbill
added
stable backport
|
@dmitrylyzo is this PR good to merge or should it wait on the other changes you have mentioned? Thanks! |
|
This PR definitely fixes stepping and makes it even. I didn't want to burden the contributor too much, but it would be better to make the slider in 1:1 ratio - this won't change UI/UX (relative to PR), but makes the code cleaner. FYI, #4758 fixes stepping (in the slider itself), but it's uneven due to rounding. As for |
…llyfin#4754 Signed-off-by: nyanmisaka <nst799610810@gmail.com>
Changes
This patch changes the subtitle sync from using a precentage to an 'slider value' which ranges from -300 to 300 (ms offset). The reasons for this is that LG WebOS doesn't jump in 0.1 slider increments as specified in the
subtitlesync.template.htmlfile but instead jumps in 1.0 increments. That results in Subtitle Sync jumping 0.6s per increment. Using a value from -300 to 300 makes LG WebOS jump 0.1s instead.There is no noticeable effect on any other platform.
Issues
Fixes #4753