Improve the user settings interface #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkanada can you show "before" and "after"? I cannot grasp the pic you show, is it the old state or the proposed? |
|
The photo in my last comment is before the change, I just replaced it with a single button to add the photo. It looks like the
|
joshuaboniface
approved these changes
Sep 29, 2019
thornbill
reviewed
Sep 29, 2019
anthonylavado
approved these changes
Sep 30, 2019
thornbill
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes the section below and replaces it with some buttons, the old process was awkward to get through. I'll add a few more commits that change the headers and remove old strings when I have time.