Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle pressing Enter to finish keyboard dragging of slider (Backport #4805) #4813

Merged
merged 1 commit into from Sep 29, 2023
Merged

Handle pressing Enter to finish keyboard dragging of slider (Backport #4805) #4813

merged 1 commit into from Sep 29, 2023

Conversation

dmitrylyzo
Copy link
Contributor

I think it is pretty safe for release.

Changes
Backport #4805

Handle pressing Enter to finish keyboard dragging of slider.
This allows to skip the timeout (1s) before sending the change event.

@dmitrylyzo dmitrylyzo added enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX labels Sep 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill thornbill merged commit 1250c76 into jellyfin:release-10.8.z Sep 29, 2023
14 checks passed
@thornbill thornbill added this to the v10.8.12 milestone Sep 29, 2023
@dmitrylyzo dmitrylyzo deleted the backport/slider-force-change branch October 2, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Milestone
v10.8.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmitrylyzo @thornbill