Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Allow card text to continue through line breaks" #484

Merged
merged 1 commit into from Sep 29, 2019
Merged

Revert "Allow card text to continue through line breaks" #484

merged 1 commit into from Sep 29, 2019

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Sep 29, 2019 •
edited by joshuaboniface

Changes
Reverts changes to allow multiline text in card footers.

Issues
Fixes #485

@dkanada
Copy link
Member

dkanada commented Sep 29, 2019

Until we can improve card generation in the dashboard we will just revert the height change for now. They basically need a special component or something that inherits most of the styling from normal cards but with a few special rules.

#397 #482

@DMouse10462 DMouse10462 mentioned this pull request Sep 29, 2019
Closed
@joshuaboniface joshuaboniface merged commit 0a6e8fe into jellyfin:master Sep 29, 2019
@dkanada dkanada mentioned this pull request Sep 30, 2019
Closed
@thornbill thornbill deleted the revert-line-wrapping branch August 24, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaboniface joshuaboniface joshuaboniface approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Images image cards display incorrectly
3 participants
@thornbill @dkanada @joshuaboniface