bandaid fix for m4b on Safari #5190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables m4b to play on iOS and Safari at the cost of force transcoding aac in m4b
|
@felix920506 thank you so much for working on this! Will be much appreciated by many I'm sure :) One naive question for me as I'm learning about how jellyfin works, is there a way to test actually playing the m4b and it fails and then the player reports to the server to request a transcoding? |
|
If Safari is the issue, why not just wrap this in a |
|
Cloudflare Pages deployment
|
|
A better fix has been identified, will close this one in favor of the alternative |
|
This is the better fix? jellyfin/jellyfin#10980 |
|
@RayBB Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables m4b to play on iOS and Safari
at the cost of force transcoding aac in m4b for everyone (Yes transcoding, not remuxing)The force transcoding for not safari has been addressed. However aac in m4b would still transcode for Safari or iOS browsers, which can be overkill in many cases. This would need to be addressed in the future.
Changes
Make web report m4b containers aren't supported
Issues
Bandaid fix for jellyfin/jellyfin#6986