Fix trailing slash when adding server causes connection faliure. #5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cloudflare Pages deployment
|
dmitrylyzo
reviewed
Apr 20, 2024
There was a problem hiding this comment.
So, this error occurs when the server has already been added to the list (before the add server page was fixed in #5205), right?
| @@ -105,6 +105,7 @@ function showServerConnectionFailure() { | |||
| export default function (view, params) { | |||
| function connectToServer(server) { | |||
| loading.show(); | |||
| server = server.replace("/$", "") | |||
There was a problem hiding this comment.
On the add server page, this is done as follows:
There was a problem hiding this comment.
I see. I re-ran some of my tests and it looks like it's specifically an issue with the media-player, not in here.
I'll close this and look into it there.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a bug where a trailing "/" will prevent a connection to a server.
Initial issues from jellyfin-media-player
Corresponding PR found here.