Update save password button label #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cloudflare Pages deployment
|
| @@ -1347,6 +1347,7 @@ | |||
| "Saturday": "Saturday", | |||
| "Save": "Save", | |||
| "SaveChanges": "Save changes", | |||
| "SavePassword": "Save Password", | |||
There was a problem hiding this comment.
Suggested change
| "SavePassword": "Save Password", | |
| "SavePassword": "Save password", |
👀
There was a problem hiding this comment.
I believe most buttons in web use Pascal casing... "Reset Password" directly below this certainly does 😉
There was a problem hiding this comment.
I don't like it though 😅
nielsvanvelzen
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the save password button text to avoid accidental password changes
Issues
Related to #5199