Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subtitle delete permission #5527

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix subtitle delete permission #5527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88d95ff
fix permission label to be less misleading
Ch1nkara May 17, 2024
f7f2a64
fix button visibility if user is not allowed to delete
Ch1nkara May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/subtitleeditor/subtitleeditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,9 @@ function fillSubtitleList(context, item) {
itemHtml += '</a>';
itemHtml += '</div>';

const buttonVisibility = item.CanDelete ? '' : 'hide';
if (!layoutManager.tv && s.Path) {
itemHtml += '<button is="paper-icon-button-light" data-index="' + s.Index + '" title="' + globalize.translate('Delete') + '" class="btnDelete listItemButton"><span class="material-icons delete" aria-hidden="true"></span></button>';
itemHtml += '<button is="paper-icon-button-light" data-index="' + s.Index + '" title="' + globalize.translate('Delete') + '" class="btnDelete listItemButton ' + buttonVisibility + '"><span class="material-icons delete" aria-hidden="true"></span></button>';
}

itemHtml += '</' + tagName + '>';
Expand Down
2 changes: 1 addition & 1 deletion src/strings/en-us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"AllowedRemoteAddressesHelp": "Comma separated list of IP addresses or IP/netmask entries for networks that will be allowed to connect remotely. If left blank, all remote addresses will be allowed.",
"AllowCollectionManagement": "Allow this user to manage collections",
"AllowContentWithTagsHelp": "Only show media with at least one of the specified tags.",
"AllowSubtitleManagement": "Allow this user to edit subtitles",
"AllowSubtitleManagement": "Allow this user to add subtitles",
"AllowFfmpegThrottling": "Throttle Transcodes",
"AllowFfmpegThrottlingHelp": "When a transcode or remux gets far enough ahead from the current playback position, pause the process so it will consume fewer resources. This is most useful when watching without seeking often. Turn this off if you experience playback issues.",
"AllowSegmentDeletion": "Delete segments",
Expand Down
Loading