Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Search Field for Tv Mode #5610

Merged

Conversation

grafixeyehero
Copy link
Member

Changes

  • Fix: for TV mode layout, when the user interacts with the search fields by selecting an alphabetic character onAlphaPicked callback, the query (search term) is not updated Properly.

Issues
Before

Search.mp4

After

Search.Fix.mp4

@grafixeyehero grafixeyehero added the bug Something isn't working label May 26, 2024
@grafixeyehero grafixeyehero added this to the v10.9.3 milestone May 26, 2024
@grafixeyehero grafixeyehero requested a review from a team as a code owner May 26, 2024 15:26
@thornbill
Copy link
Member

Please update this to target the release branch for 10.9.

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my little knowledge of React 😅, looks fine.

This needs to be rebased on release-10.9.z branch if we want it in 10.9.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label May 26, 2024
@jellyfin-bot

This comment has been minimized.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/apps/dashboard/components/AppTabs.tsx Outdated Show resolved Hide resolved
src/components/playback/playbackmanager.js Outdated Show resolved Hide resolved
@grafixeyehero grafixeyehero changed the base branch from master to release-10.9.z May 26, 2024 17:01
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label May 26, 2024
@thornbill thornbill modified the milestones: v10.9.3, v10.9.4 May 27, 2024
@thornbill thornbill added stable backport Backport into the next stable release regression We broke something labels May 29, 2024
@thornbill thornbill added this to In progress in Release 10.9.z via automation May 29, 2024
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thornbill thornbill merged commit 003bc94 into jellyfin:release-10.9.z May 30, 2024
11 checks passed
Release 10.9.z automation moved this from In progress to Done May 30, 2024
joshuaboniface pushed a commit that referenced this pull request Jun 1, 2024
Fix Search Field for Tv Mode

Original-merge: 003bc94

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants