Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rotten Tomatoes icons #785

Merged
merged 1 commit into from Feb 12, 2020
Merged

Update Rotten Tomatoes icons #785

merged 1 commit into from Feb 12, 2020

Conversation

heyhippari
Copy link
Contributor

Changes

Brings the icons up to date with the current Rotten Tomatoes designs. Replaces PNG icons with SVG ones to allow better scaling.

image

image

Issues

None

@anthonylavado anthonylavado added this to In progress in Release 10.5.0 via automation Feb 12, 2020
@anthonylavado anthonylavado requested a review from a team February 12, 2020 07:23
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the license for those assets?

@dkanada dkanada merged commit 077b682 into jellyfin:master Feb 12, 2020
Release 10.5.0 automation moved this from In progress to Done Feb 12, 2020
@heyhippari
Copy link
Contributor Author

What is the license for those assets?

Same as those we used before: https://www.rottentomatoes.com/help_desk/licensing

It's merely a refresh of the icons to use the new ones.

@JustAMan
Copy link
Contributor

So it says:

If you would like to use any of our trademarks or logos, please submit a request with details of your planned usage via our Business Proposal Form for review and access to assets.

I am unaware of us receiving their permission... we probably should, pinging @anthonylavado

@anthonylavado
Copy link
Member

Where do we even get these scores? Is it from them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants