Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Space-Key as PlayPause-Key #805

Closed
wants to merge 1 commit into from
Closed

Conversation

screeny05
Copy link

This PR adds the spacebar as a key to toggle playback in the videoplayer.

Changes
Add additional key-shortcut in videoplayer

This PR adds the spacebar as a key to toggle playback in the videoplayer.
@dmitrylyzo
Copy link
Contributor

In TV layout, Space triggers focused buttons.
It could be ignored here

if (layoutManager.tv && keyboardnavigation.isNavigationKey(key)) {

At current moment, Space is handled when OSD is hidden.

if (!currentVisibleMenu && 32 === e.keyCode) {

@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Feb 19, 2020

Just tested this PR changes on master (Desktop/TV):

  • When OSD is visible, focus is on button Play/Pause, and we get playPause + click on button Play/Pause (playPause again). So this does not work as expected.
  • The only way to make it work is to first click on videoplayer. In this case, focus will be on player instead of button.

@heyhippari heyhippari added this to the Release 10.6.0 milestone Mar 4, 2020
@dkanada
Copy link
Member

dkanada commented Mar 11, 2020

@screeny05 did you have plans to fix the issues mentioned earlier?

@dkanada dkanada added the question Further information is requested label Mar 12, 2020
@dkanada
Copy link
Member

dkanada commented Mar 31, 2020

I'm closing this for now from lack of movement, but I agree there are some inconsistencies that need to be resolved with the space key. Feel free to open this back up again if you plan to fix the compatibility issues mentioned above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants