Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interpretation of Dolby Atmos as supporting TrueHD #139

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Remove interpretation of Dolby Atmos as supporting TrueHD #139

merged 1 commit into from
Jun 9, 2023

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Jan 4, 2023 •
edited

Was introduced in #79

Issues
Fixes #111
Fixes #118
Fixes #129 (#129 (comment))
Fixes jellyfin/jellyfin-web#4237

We need someone to recheck #59. But this may be due to a transcoding problem (jellyfin/jellyfin#9016 (comment)).

@dmitrylyzo dmitrylyzo added the bug Something isn't working label Jan 4, 2023
@anthonylavado anthonylavado self-requested a review January 4, 2023 20:20
@iwatch-x
Copy link

when will this be added to the master ?

@dmitrylyzo dmitrylyzo mentioned this pull request Jun 9, 2023
Closed
@anthonylavado anthonylavado removed their request for review June 9, 2023 16:07
anthonylavado
anthonylavado approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@anthonylavado anthonylavado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informally I approve this on a code basis, as I don't have the ability to test anything LG outside of the emulator.

@dmitrylyzo Feel free to merge at will.

@dmitrylyzo dmitrylyzo merged commit a498a2a into jellyfin:master Jun 9, 2023
@dmitrylyzo dmitrylyzo deleted the dont-lie-about-truehd branch June 9, 2023 17:44
@Schaka
Copy link

Schaka commented Jun 12, 2023

Ran into this problem with a TrueHD stream that wasn't playing audio. If this is pushed into a release, I'll happily test it on my LG C1.

@Schaka
Copy link

Schaka commented Jun 12, 2023 •
edited

Leaving another comment instead of editing in case anyone has notifications on. I managed to compile the master branch and deploy it on my TV. Took some trial and error to realize I actually need to delete the Jellyfin app manually before reinstalling it (somehow it seems some things may have been cached?).

Either way, things work. Movie that only has a TrueHD stream gets transcoded to AAC. Thank you for this.
Hopefully I can find the time in a couple days to get to that DoVi mp4 issue and make a PR for that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonylavado anthonylavado anthonylavado approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@dmitrylyzo @iwatch-x @Schaka @anthonylavado