Skip to content

Commit

Permalink
Apply review suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
Shadowghost committed Feb 19, 2023
1 parent 6b24798 commit a1c9fd9
Showing 1 changed file with 20 additions and 8 deletions.
28 changes: 20 additions & 8 deletions MediaBrowser.Model/Dlna/ConditionProcessor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,16 @@ private static bool IsConditionSatisfied(ProfileCondition condition, int? curren
var conditionType = condition.Condition;
if (condition.Condition == ProfileConditionType.EqualsAny)
{
return condition.Value.Split('|')
.Select(s => int.TryParse(s, NumberStyles.Any, CultureInfo.InvariantCulture, out int n) ? n : (int?)null)
.Where(n => n is not null)
.Contains(currentValue.Value);
foreach (var singleConditionString in condition.Value.AsSpan().Split('|'))
{
if (int.TryParse(singleConditionString, NumberStyles.Any, CultureInfo.InvariantCulture, out int conditionValue)
&& conditionValue.Equals(currentValue))
{
return true;
}
}

return false;
}

if (int.TryParse(condition.Value, NumberStyles.Any, CultureInfo.InvariantCulture, out var expected))
Expand Down Expand Up @@ -224,10 +230,16 @@ private static bool IsConditionSatisfied(ProfileCondition condition, double? cur
var conditionType = condition.Condition;
if (condition.Condition == ProfileConditionType.EqualsAny)
{
return condition.Value.Split('|')
.Select(s => double.TryParse(s, NumberStyles.Any, CultureInfo.InvariantCulture, out double n) ? n : (double?)null)
.Where(n => n is not null)
.Contains(currentValue.Value);
foreach (var singleConditionString in condition.Value.AsSpan().Split('|'))
{
if (double.TryParse(singleConditionString, NumberStyles.Any, CultureInfo.InvariantCulture, out double conditionValue)
&& conditionValue.Equals(currentValue))
{
return true;
}
}

return false;
}

if (double.TryParse(condition.Value, NumberStyles.Any, CultureInfo.InvariantCulture, out var expected))
Expand Down

0 comments on commit a1c9fd9

Please sign in to comment.