Skip to content

Commit

Permalink
Fix direct play
Browse files Browse the repository at this point in the history
The SupportsDirectStream is a little bit misleading as it actually means "Supports Direct Play"

Signed-off-by: gnattu <gnattuoc@me.com>
  • Loading branch information
gnattu committed May 16, 2024
1 parent 6b9b392 commit f1c000e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions Jellyfin.Api/Controllers/UniversalAudioController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,10 @@ public class UniversalAudioController : BaseJellyfinApiController
return Redirect(mediaSource.Path);
}

// This one is currently very misleading as the SupportsDirectStream is always false
// This one is currently very misleading as the SupportsDirectStream actually means "can direct play"
// The definition of DirectStream also seems changed during development
// It used to mean HTTP direct streaming, but now HLS is used even for DirectStream
var isStatic = mediaSource.SupportsDirectStream;
if (mediaSource.TranscodingSubProtocol == MediaStreamProtocol.hls)
if (!isStatic && mediaSource.TranscodingSubProtocol == MediaStreamProtocol.hls)
{
// hls segment container can only be mpegts or fmp4 per ffmpeg documentation
// ffmpeg option -> file extension
Expand Down

0 comments on commit f1c000e

Please sign in to comment.