Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: GitHub stale issue action doesn't seem to be closing old issues #10333

Closed
1 task done
jacobslusser opened this issue Oct 3, 2023 · 8 comments
Closed
1 task done
Labels
bug Something isn't working stale Stale and will be closed if no activity occurs

Comments

@jacobslusser
Copy link
Contributor

Please describe your bug

As of this writing, there are 703 open issues in the Jellyfin project. If you sort by least recently updated (and ignore those with the following tags: regression, security, roadmap, future, feature, enhancement, confirmed) there are a number of open issues that should have been closed by the GitHub stale action, .github/workflows/repo-stale.yaml

The action logs suggest a fix might be to increase the number of operations, however, that would need to be confirmed.

Jellyfin Version

Other

if other:

N/A

Environment

N/A

Jellyfin logs

N/A

FFmpeg logs

N/A

Please attach any browser or client logs here

N/A

Please attach any screenshots here

image

image

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jacobslusser jacobslusser added the bug Something isn't working label Oct 3, 2023
@jacobslusser
Copy link
Contributor Author

I can submit a PR to fix this issue if the maintainers agree with the issue and probable cause.

@sevenrats
Copy link
Member

we just added a handful of members to the triage team, and we are in the process of cleaning this up now. how do you want this issue to proceed? i suspect all these old issues are going to get handled by human intelligence is the next few days, but if you think your PR is still a good idea it would be appreciated.

@jacobslusser
Copy link
Contributor Author

I have submitted the PR. It has been approved but not merged yet. Happy to help.

@jacobslusser
Copy link
Contributor Author

I don't believe the PR that was intended to fix this has worked. I still see the "stale issue" action starting from the most recent issue on every run, instead of from where it finished in the last run....

@jacobslusser jacobslusser reopened this Oct 13, 2023
@srcrist
Copy link

srcrist commented Oct 19, 2023

Jacob, did you have any thoughts on how to proceed here?

@jacobslusser
Copy link
Contributor Author

I can only conclude that the stale action doesn't work as advertised and is not persisting state between executions, despite their documentation and my every attempt to get it to do so.

Here is what I think I will do to work around the issue:

  1. Increase the operations-per-run to maybe 500 -- at least for the time being to work through the backlog and then maybe we can decrease it again. Ideally we don't want that many operations per run because it could cause the GitHub API to block or throttle us.
  2. Add the ascending: true property. This will have the effect of starting from the oldest and then going to the newest -- which is more appropriate for the goal of the bot to find stale issues.
  3. Change the cron schedule back to once a day instead of twice, since that change was based on the assumption it would be stateful and resume where it previously left off.

@jellyfin-bot
Copy link
Contributor

This issue has gone 120 days without an update and will be closed within 21 days if there is no new activity. To prevent this issue from being closed, please confirm the issue has not already been fixed by providing updated examples or logs.

If you have any questions you can use one of several ways to contact us.

@jellyfin-bot jellyfin-bot added the stale Stale and will be closed if no activity occurs label Feb 19, 2024
@jellyfin-bot
Copy link
Contributor

This issue was closed due to inactivity.

@jellyfin-bot jellyfin-bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Stale and will be closed if no activity occurs
Projects
Archived in project
Development

No branches or pull requests

4 participants