Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logging doesn't work #1130

Closed
platinum55 opened this issue Mar 18, 2019 · 13 comments
Closed

Debug logging doesn't work #1130

platinum55 opened this issue Mar 18, 2019 · 13 comments
Labels
bug Something isn't working

Comments

@platinum55
Copy link

Issue:

  1. Go on Expert - Logs
  2. Click "Enable debug logging"
  3. Click again on the menu link, the checkbox isnt checked and there is no debugging enabled

What I found out:

Browser did a POST request with "EnableDebugLevelLogging: true" inside

@platinum55 platinum55 added the bug Something isn't working label Mar 18, 2019
@ploughpuff
Copy link
Contributor

Thanks for posting as I'm experiencing the same with latest master..

@ploughpuff
Copy link
Contributor

Seems EnableDebugLevelLogging was pruned under PR #830 (7554f63)

@Bond-009 As this removal appears designed, what is the correct method for enabling the LogDebug() writes please?

@Bond-009
Copy link
Member

You need to change the logger config manually.

@ploughpuff
Copy link
Contributor

Ok, how do you do that?

Also, do we need an issue raising on jellyfin-web to remove the checkbox?

@platinum55
Copy link
Author

I tried setting "EnableDebugLevelLogging = true" in the main config file, but it had no effect - how to enable debug-logging manually?

@joshuaboniface
Copy link
Member

In the logging.json file under the configdir (default datadir/config), you change:

"MinimumLevel": "Information",

to

"MinimumLevel": "Debug",

And then restart Jellyfin. The debug messages show up in the log with the tag DBG.

@joshuaboniface
Copy link
Member

joshuaboniface commented Mar 18, 2019

I do agree we should simply prune this out of the WebUI, or add an interface to edit the logging.json file. I'm less a fan of the latter since it just adds more complexity, but perhaps it could be made into a runtime flag for that current session, i.e. an in-memory config change - do you know if that's possible @Bond-009?

@platinum55
Copy link
Author

First, thank you very much for this information! About the complexity: I think it's better to give the user more power instead of moving options out of view. The "advanced" tab is maybe the best target for this, as it was already :)

@joshuaboniface
Copy link
Member

I mean complexity in terms of having to get the server to edit another configuration file. It's doable, but I'd rather it be via some sort of physical editor; the logging configuration is quite complex and isn't well suited to buttons in a GUI.

@JustAMan
Copy link
Contributor

As a stopgap measure we should be saying this much in documentation:

In the logging.json file under the configdir (default datadir/config), you change:

"MinimumLevel": "Information",

to

"MinimumLevel": "Debug",

And then restart Jellyfin. The debug messages show up in the log with the tag DBG.

And hide the option from Web UI (or make it a link pointing to the documentation).

@stale
Copy link

stale bot commented Jul 29, 2019

Issues go stale after 60d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 7d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale Stale and will be closed if no activity occurs label Jul 29, 2019
@stale stale bot closed this as completed Aug 5, 2019
Issue Triage for Main Repo automation moved this from Needs triage to Closed/Done Aug 5, 2019
@JustAMan
Copy link
Contributor

Uhh, this should be fixed sometime.

@JustAMan JustAMan reopened this Sep 25, 2019
Issue Triage for Main Repo automation moved this from Closed/Done to Needs triage Sep 25, 2019
@stale stale bot removed stale Stale and will be closed if no activity occurs labels Sep 25, 2019
@JustAMan JustAMan added this to To Do in Release 10.4.1 via automation Sep 25, 2019
@JustAMan JustAMan removed this from To Do in Release 10.4.1 Sep 25, 2019
@JustAMan JustAMan added this to To Do in Release 10.4.0 via automation Sep 25, 2019
@JustAMan
Copy link
Contributor

Fixed by jellyfin/jellyfin-web#272

Issue Triage for Main Repo automation moved this from Needs triage to Closed/Done Sep 25, 2019
@JustAMan JustAMan moved this from To Do to Done in Release 10.4.0 Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

5 participants