Remove option to enable debug logging #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
approved these changes
Apr 25, 2019
DrPandemic
approved these changes
Apr 26, 2019
|
@DrPandemic We do actually have a debug log level, but you have to enable it in a file on the server. |
|
@dkanada Should we keep a link to the documentation, and add a corresponding page with details on turning on Debug logging? |
|
@anthonylavado I'd like to get some of the current PRs merged before I work on more. It's getting hard to avoid possible merge conflicts with all the changes and I have like nine or ten branches on my local copy of the source. |
anthonylavado
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to kill some time and I remember someone mentioning this option doesn't actually work. We could also add an option to set the specific logging level or just leave this option in the runtime flags, opened this PR for discussion.