Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music Star Rating #1435

Closed
WisdomCode opened this issue Jun 3, 2019 · 5 comments
Closed

Music Star Rating #1435

WisdomCode opened this issue Jun 3, 2019 · 5 comments
Labels
feature Adding a new feature, or substantial improvements on existing functionality

Comments

@WisdomCode
Copy link

Describe the feature you'd like
Beside the now common "favorit" button for organizing your favorite music, there is also the star rating, giving singular songs a number of stars between 1 and 5.
I would love to see support for this more sophisticated way of rating your music.
The stars can even be saved inside the mp3 file, so it would be nice to directly get them from there when scanning. For a supporting scanner, you may refer to banshee or ampache. For a working Tag editor fully supporting it, you may refer to eyed3. From their
Code, I concluded that this specific Tag is saved under the value 'POPM' (see Line 48). If you want help on this task, I'd be glad to help.

@WisdomCode WisdomCode added the feature Adding a new feature, or substantial improvements on existing functionality label Jun 3, 2019
@ArnaudB88
Copy link

I would also love this feature. For me, it is a requirement to start using this system.

But I think saving the score should be done in the database so different users can rate different on one item.

@WisdomCode
Copy link
Author

WisdomCode commented Jun 8, 2019

This is actually also possible in the metadata. There can be multiple ratings, they are saved under a name, email or similar value. However, I can see that point, but for keeping those values for interoperability, some way for writing and reading those values (it may be an api or something, not necessarily a default option) would be really nice.

@kyriakosbrastianos
Copy link

Just use the vorbis comment way that are simply named "RATING" and a value from 1 to 5 or 1 to 10. This kind of tag names are also recognized from kodi and other players. I see no reason to add name, email and other no standard values and make it incompatible to be read from other players.

@WisdomCode
Copy link
Author

The Popularity is a standard way to save the star rating, I know at least 3 player working with those and its part of the original definition of idv3. It allows for multiple ratings on one song, like @ArnaudB88 requests. For the exact usage of naming etc., you may refer to those players using it (banshee, ampache etc).
However, if this is a more popular way to save star rating, then this may be a better way to go. Maybe you could elaborate and explain in more detail how this works? Are these tag names recognized by emby already? What other players support it other than Kodi?

@jellyfin-bot
Copy link
Contributor

We are moving all feature and enhancement requests to our new Fider platform here. This new platform lets people vote on and better manage such requests.
This request now lives here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding a new feature, or substantial improvements on existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants