Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile to build Debian package #17

Closed
nvllsvm opened this issue Dec 10, 2018 · 3 comments
Closed

Add Dockerfile to build Debian package #17

nvllsvm opened this issue Dec 10, 2018 · 3 comments
Labels
build Issues with the build process

Comments

@nvllsvm
Copy link
Member

nvllsvm commented Dec 10, 2018

Building packages often requires multiple steps and customized environments. Having a Dockerfile to build the Debian package:

  • Creates portable, reproducible build environments.
  • Allows one to build the Debian package on any system.
  • Documents how exactly to build the package. Our ancestor project was notoriously bad at this.

In other words - one should be able to build a Debian package doing nothing more than this. This example assumes #18 has been implemented.

$ git clone https://github.com/jellyfin/jellyfin
$ cd jellyfin/jellyfin
$ docker build -f Dockerfile.debian_package .
@joshuaboniface
Copy link
Member

joshuaboniface commented Dec 10, 2018

The current build procedure is just as simple and has no dependency on Docker, just on the dotnet-sdk-2.1 package and standard debuild framework - with Mono it was a nightmare, but luckily .NET Core made this a lot easier. However I don't see a reason we can't do both, as long as the Docker setup doesn't preclude doing it the old-fashioned non-Docker way.

@nvllsvm
Copy link
Member Author

nvllsvm commented Dec 10, 2018

@joshuaboniface One of the intentions of having this in addition to the Debian build files is that it will make CI/CD integration much nicer.

@joshuaboniface
Copy link
Member

Yup agreed on the CI integration, just wanted to be sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues with the build process
Projects
None yet
Development

No branches or pull requests

3 participants