New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirection with baseUrl issues #2086
Comments
That's the expected behavior if a baseurl is set. The API endpoint would be The redirection from root when a baseurl is set is quite naive and redirects any invalid location at the root to the main page. |
Well got tons of users updated with the new path without warning and ways to tell them ;) Does not seems really pretty for API consumers, API endpoint should not redirect with an error indicating proper new endpoint or redirect to proper new url. |
These users need to read the release notes for JF 10.4.1. To expedite, they can run This has been an ongoing support problem of people not reading the release notes that make EXTREMELY clear what needs to be done to fix this. I do agree with you there for proper redirects, but that again kinda defeats the BaseURL purpose, since then you're then aliasing |
Well on the user side, this baseurl and it's impact should not have been added automatically on 10.4 ;) Is that baseurl thing even advertised in the auto detection answer? How would a remote that auto detect Jellyfin find this and properly auto configure, without user having the deal with errors and manual typing. |
Bump on this, do you intend to expose that base URL in the discovering packet and provide a proper way for API consumers to get it given an IP. |
This is fixed in master, discovery responds with the baseurl appended to the ip |
Added to what field? Link to PR? What about the case of non working discovery? What about redirecting System/Info and providing the value there? |
The |
Ok thanks, that's a start for the vast majority. Just to be sure the mater nightly are https://repo.jellyfin.org/releases/server/windows/nightly/jellyfin-nightly_20200117_windows-x64.zip ? |
Yep |
Well can't test facing #2255 and same no error in logs :( |
Ok so now I can test and it's broken :) As soon as I fill a baseurl in the networking settings Jellyfin stop answering to the auto discover packet. Tested with https://repo.jellyfin.org/releases/server/windows/nightly/jellyfin-nightly_20200130_windows-x64.zip |
So now that it's fixed and working can we talk about the last case: manual setup? Since there's a redirect there's no security and so nothing to hide. It would be nice that http://xxx:8096/System/Info/Public properly redirect to http://xxxx:8096/baseurl/System/Info/Public that then already properly expose the baseurl in "LocalAddress":"http://xxx:8096/baseurl" That would solve the last bit of configuration easiness for users. |
@Tolriq so that would be useful when a user incorrectly enters the wrong URL and a redirect would resolve that specific issue? Or were you thinking of a different scenario? |
User should not have to enter an url if possible just an host and a port, client should detect the baseurl if present and it can and if using http or https. |
So I suppose this is a no? :) |
Didn't see this message, apologies. I'm not keen on the idea for the base URL, because it's not set by default, but the other fields can all be handled on the clients themselves. |
I'm sorry but I have no idea what you are trying to tell in your answer. The thing is that you already do a blind redirect so this adds no security to hide the baseurl and a client can detect that parse the url and try to guess the data. The end user should not have to know or have to type manually that base url, this brings no security just complexity. |
@Tolriq I was wondering why cannot you try hitting What you want us to do is somewhat about working around users, and that code (from my point of view) should live as close to a user as possible, hence in a client... |
What if it's not an Jellyfin server and a global redirect from a proxy? I need to read the index.html content to be sure what it is? This is all but a clean and proper solution. Why announce the baseurl in the auto detection? Why do the redirect in the first place, the user should know the full path right? If there was no redirect to bring some kind of security then yes force the user to know the details. If there's a global redirect then having the end user to know the details to configure the client is not nice and bring complexity on his shoulders for 0 benefits. At some point when I share my Jellyfin to other people they should not have to know the internal configuration details and have a complex setup screen to type on a small screen. Should a user have to type "http://192.168.1.10:8096/toto" or just 192.168.1.10 with an already filed box for the port? You need to think about users as users and not the tech guy that have configured Jellyfin server. Having the end user manually enter the base url when you already have a global redirect is a UX non sense. Edit: And just for the context, I've been dealing with a few millions users over the last 10 years, so have a "little" background about users needs and limitations when it comes to connect to Media Centers. |
That redirect isn't here to stay, it will get removed |
In that case it's different, just please return a clear error / message something so clients can know that's it's a Jellyfin server and not something else and help the user filling the proper fields. |
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments. |
It seems some API end points redirection are redirecting to index and not the proper url.
http://10.0.0.4:8096/System/Info redirect to http://10.0.0.4:8096/jellyfin/web/index.html
The text was updated successfully, but these errors were encountered: