Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local trailer from the "trailers" folder is not used. #3422

Closed
sl1288 opened this issue Jun 22, 2020 · 7 comments · Fixed by #7186
Closed

Local trailer from the "trailers" folder is not used. #3422

sl1288 opened this issue Jun 22, 2020 · 7 comments · Fixed by #7186
Labels
bug Something isn't working confirmed This issue has been reviewed and confirmed

Comments

@sl1288
Copy link

sl1288 commented Jun 22, 2020

With an directory structure like this:
\Film (2000)\Film (2000).mkv
\Film (2000)\trailers\Film (2000).mkv
\Film (2000)\Extras\Honest Trailer.mkv

The File "\Film (2000)\Extras\Honest Trailer.mkv" is played as a local trailer.

With an directory structure like this:
\Film (2000)\Film (2000).mkv
\Film (2000)\trailers\Film (2000).mkv

It does play an youtube trailer.

This was working in an older version, see issue #1639

@sl1288 sl1288 added the bug Something isn't working label Jun 22, 2020
@stale
Copy link

stale bot commented Oct 21, 2020

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale Stale and will be closed if no activity occurs label Oct 21, 2020
@sl1288
Copy link
Author

sl1288 commented Oct 24, 2020

Tested version: a69397d

Trailer playback does work with this folder structure now:
\Film (2000)\Film (2000).mkv
\Film (2000)\trailers\Film (2000).mkv

But with this structure "\Film (2000)\Extras\Honest Trailer.mkv" is still played, instead of "\Film (2000)\trailers\Film (2000).mkv"
\Film (2000)\Film (2000).mkv
\Film (2000)\trailers\Film (2000).mkv
\Film (2000)\Extras\Honest Trailer.mkv

@stale stale bot removed the stale Stale and will be closed if no activity occurs label Oct 24, 2020
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale Stale and will be closed if no activity occurs label Mar 19, 2021
@cvium
Copy link
Member

cvium commented Apr 19, 2021

Caused by this line

extras > trailers.

Whether the existence of a trailers folder means it should ignore extras is up for debate.

@stale stale bot removed the stale Stale and will be closed if no activity occurs label Apr 19, 2021
@cvium cvium added confirmed This issue has been reviewed and confirmed stale Stale and will be closed if no activity occurs labels Apr 19, 2021
@stale stale bot removed the stale Stale and will be closed if no activity occurs label Apr 19, 2021
@taylor-schneider
Copy link

any fixes?

@crobibero
Copy link
Member

crobibero commented Dec 22, 2021

#7028

Well, this PR fixed reading the folders, but did nothing about the ordering.

@hasezoey
Copy link

i dont know the current state of this issue, but i would also be in favor of having the folder trailers take priority over extras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This issue has been reviewed and confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants