Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extras folders #7028

Merged
merged 4 commits into from
Dec 22, 2021
Merged

Fix extras folders #7028

merged 4 commits into from
Dec 22, 2021

Conversation

cvium
Copy link
Member

@cvium cvium commented Dec 20, 2021

Fixed "trailers", theme song and theme videos.

Copy link
Member

@1337joe 1337joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved because it now picks up trailers, though in testing I noticed that running Refresh Metadata on a movie doesn't chain down to trailers and extras, which should be picked up as owned items.

@cvium
Copy link
Member Author

cvium commented Dec 20, 2021

I noticed that running Refresh Metadata on a movie doesn't chain down to trailers and extras

@1337joe What do you mean? When I refresh a movie it calls RefreshExtras.

@1337joe
Copy link
Member

1337joe commented Dec 20, 2021

What do you mean? When I refresh a movie it calls RefreshExtras.

I guess it's kind of hard to see the effect, try these steps:

  1. Open a movie that has extras
  2. Video extras will have screenshots from the video as their cover image - edit images for the extras and delete the images
  3. Refresh the page - the cover image will revert to art from the parent movie, typically the backdrop image I believe
  4. On the movie, Refresh Metadata > Mode: Replace All Metadata, Replace Existing Images: true
  5. Wait for the refresh job to finish, then refresh the page again - the extras will not have re-extracted their cover images

Alternately, set a breakpoint in ProviderManager.GetMetadataProvidersInternal and you can directly see that metadata providers are only queried for the Movie, not any of the extras/trailers/etc.

@cvium
Copy link
Member Author

cvium commented Dec 20, 2021

What do you mean? When I refresh a movie it calls RefreshExtras.

I guess it's kind of hard to see the effect, try these steps:

  1. Open a movie that has extras

  2. Video extras will have screenshots from the video as their cover image - edit images for the extras and delete the images

  3. Refresh the page - the cover image will revert to art from the parent movie, typically the backdrop image I believe

  4. On the movie, Refresh Metadata > Mode: Replace All Metadata, Replace Existing Images: true

  5. Wait for the refresh job to finish, then refresh the page again - the extras will not have re-extracted their cover images

Alternately, set a breakpoint in ProviderManager.GetMetadataProvidersInternal and you can directly see that metadata providers are only queried for the Movie, not any of the extras/trailers/etc.

Is this because of my changes or does 10.7 behave the same way?

@1337joe
Copy link
Member

1337joe commented Dec 20, 2021

10.7 refreshes metadata for all items under the movie.

It looks like your changes: when I restore the RefreshedOwnedItems override that you deleted from Movie it works like it used to.

@crobibero crobibero merged commit 00211ca into jellyfin:master Dec 22, 2021
@1337joe 1337joe mentioned this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants