Add "Production" and "TV" episode orders to the metadata editor. #6528
Conversation
| string.Equals(displayOrder, "absolute", StringComparison.Ordinal) ? TvGroupType.Absolute : | ||
| string.Equals(displayOrder, "dvd", StringComparison.Ordinal) ? TvGroupType.DVD : | ||
| string.Equals(displayOrder, "tv", StringComparison.Ordinal) ? TvGroupType.TV : |
There was a problem hiding this comment.
As far as I know it's supposed to be used for shows with episodes that were grouped differently in specific regions, yet unfortunately it's not a very consistent option:
There was a problem hiding this comment.
In that case I think "tv" might be a bad name. Not sure what it should be called though.
There was a problem hiding this comment.
Neither do I in that case, the names used by the website are as descriptive as they get.
There was a problem hiding this comment.
Can we call it "regional"? Does that make sense?
There was a problem hiding this comment.
Is not "TV" = "Syndication"? See https://en.wikipedia.org/wiki/Broadcast_syndication
Why not add other types? For example "La casa de papel" (Money Heist) had Season 1 Spain version (aired, 15 episodes) and Netflix version (digital, 22 episodes) with different durations and number.
There was a problem hiding this comment.
The other types I hadn't added in this PR have obvious names (OriginalAirDate, StoryArc, Digital) so maybe just calling TV "Syndication" would be enough to have all of them?
There was a problem hiding this comment.
Why not list all types and in the same order as here?
There was a problem hiding this comment.
I have pushed a commit listing all the types found in the client API.
There was a problem hiding this comment.
I think using the values provided by the API are sensible, if we rename them then it's on us to come up with better mappings.
|
When multiple episode orders of a same type are available on TMDB for a series (for instance, One Piece has two different "absolute" orders), is there a way to control (or predict for that matter) which episode order will be fetched by TMDBLib? |
| string.Equals(displayOrder, "absolute", StringComparison.Ordinal) ? TvGroupType.Absolute : | ||
| string.Equals(displayOrder, "dvd", StringComparison.Ordinal) ? TvGroupType.DVD : | ||
| string.Equals(displayOrder, "tv", StringComparison.Ordinal) ? TvGroupType.TV : |
There was a problem hiding this comment.
I think using the values provided by the API are sensible, if we rename them then it's on us to come up with better mappings.
I think the question would be how the TMDBLib API returns them, i.e. what is matched to what for this particular edge case. Since this is an addition though, and the existing system is just as potentially ambiguous, I don't know how much we should dwell on it too much in this (simple) PR. |
Currently, the metadata editor allows episodes from series to pull the TMDB information and be grouped by aired date, absolute order, or DVD order. TMDbLib exposes several more episode ordering schemas yet not all are made available in Jellyfin.
Since the library takes care of fetching the information, this change is as simple as adding the proper options in the server as well as the web client. Corresponding PR for jellyfin-web is here.