Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Production" and "TV" episode orders to the metadata editor. #6528

Merged
merged 3 commits into from Mar 11, 2022
Merged

Add "Production" and "TV" episode orders to the metadata editor. #6528

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86a5e72
Add "Production" and "TV" episode orders.
oledfish Sep 7, 2021
3b075a5
Merge branch 'jellyfin:master' into additional-episode-orders
oledfish Jan 17, 2022
47269d5
Add all TMDB episode orders
oledfish Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs
View file
Open in desktop
Expand Up @@ -148,8 +148,10 @@ public async Task<TvShow> GetSeriesAsync(int tmdbId, string language, string ima
private async Task<TvGroupCollection> GetSeriesGroupAsync(int tvShowId, string displayOrder, string language, string imageLanguages, CancellationToken cancellationToken)
{
TvGroupType? groupType =
string.Equals(displayOrder, "production", StringComparison.Ordinal) ? TvGroupType.Production :
string.Equals(displayOrder, "absolute", StringComparison.Ordinal) ? TvGroupType.Absolute :
string.Equals(displayOrder, "dvd", StringComparison.Ordinal) ? TvGroupType.DVD :
string.Equals(displayOrder, "tv", StringComparison.Ordinal) ? TvGroupType.TV :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is TV order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know it's supposed to be used for shows with episodes that were grouped differently in specific regions, yet unfortunately it's not a very consistent option:

  • Naruto shows a five-season grouping as opposed to other options that show either a four-season grouping or a single season with all episodes lumped in.
  • One Piece has all its episodes grouped into a single season in TV order, while other options are far better organized.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I think "tv" might be a bad name. Not sure what it should be called though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither do I in that case, the names used by the website are as descriptive as they get.

Copy link
Member

@cvium cvium Sep 10, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it "regional"? Does that make sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not "TV" = "Syndication"? See https://en.wikipedia.org/wiki/Broadcast_syndication
Why not add other types? For example "La casa de papel" (Money Heist) had Season 1 Spain version (aired, 15 episodes) and Netflix version (digital, 22 episodes) with different durations and number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other types I hadn't added in this PR have obvious names (OriginalAirDate, StoryArc, Digital) so maybe just calling TV "Syndication" would be enough to have all of them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not list all types and in the same order as here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed a commit listing all the types found in the client API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using the values provided by the API are sensible, if we rename them then it's on us to come up with better mappings.

null;

if (groupType == null)
Expand Down