New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker Healthcheck #6680
Add Docker Healthcheck #6680
Conversation
Co-authored-by: Cody Robibero <cody@robibe.ro>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also may not work if the server the server has RequireHttps
enabled
Co-authored-by: Cody Robibero <cody@robibe.ro>
@crobibero Won't it also break if the server isn't listening on localhost? |
Yeah that would also not work… maybe we should just have the health check url default to local host:8096 but allow it to be completely overridden using an ENV variable |
Should I create a new env var? If there is a reverse proxy it must be the address and port without the reverse proxy. |
I want to say yes, but it’ll have to be tested by someone who terminates ssl with Jellyfin and has RequireHttps enabled |
I personally use a reverse proxy but without https between jellyfin and the proxy. But I could test it. |
I believe that’s how most people have Jellyfin set up. Additionally, with 10.8 (unstable) there is an automatic redirect to remove the baseUrl when getting health status |
As long as a trusted certificate is used and require https is enabled it is working. If you have any other edge cases that I should test, let me know. |
Do you mean xxx/baseurl/health -> xxx/health or xxx/health -> xxx/baseurl/health? |
I also would like to add the option |
xxx/health -> xxx/baseurl/health |
Co-authored-by: Cody Robibero <cody@robibe.ro>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @MarcelCoding can you add the same to the https://github.com/jellyfin/jellyfin-metapackages Dockerfiles?
Changes
Added Docker Healthcheck to ensure jellyfin is always available. (e.g. This enables reverse proxies (traefik) to remove jellyfin from the routes if it is overloaded.)
Issues
Fixed #5760
PS: squash the pr, if the signature should be correct :) I did it in a codespace.