Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Grouped version count is not changed when a version is deleted from the file system #9281

Open
1 task done
boblinthewild opened this issue Feb 8, 2023 · 13 comments
Labels
bug Something isn't working confirmed This issue has been reviewed and confirmed

Comments

@boblinthewild
Copy link

boblinthewild commented Feb 8, 2023

Please describe your bug

After grouping one or more versions, the group count is displayed on the poster that is displayed for that group. As well, Media Info shows all the versions in that group, and it's possible to select which version to play.

Subsequently deleting one or more versions from the file system and rescanning the library, the deleted versions are correctly removed from Media Info and version selection from Play. However, the version count that is displayed on the poster is not decremented to account for the deleted version(s).

Example/steps to reproduce:

[NOTE: this applies to multiple versions stored in their own individual folders, rather than multiple versions stored within the same folder]

  1. Group two items/versions of the same movie, verifying that the poster count = 2
  2. In the file system, delete one of the items that had been grouped in Jellyfin
  3. Rescan the library containing the original group for changed/updated media
  4. The poster count still = 2, even though Media Info now shows only one item
  5. The Split function is no longer available, so there is no way to change the count shown on the poster

Jellyfin Version

10.8.0

if other:

10.8.9

Environment

- OS: Windows 11
- Virtualization: None
- Clients: Browser
- Browser: MS Edge
- FFmpeg Version: n/a
- Playback Method: n/a
- Hardware Acceleration: n/a
- Plugins: None
- Reverse Proxy: n/a
- Base URL: n/a
- Networking: n/a
- Storage: n/a

Jellyfin logs

No response

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@boblinthewild boblinthewild added the bug Something isn't working label Feb 8, 2023
@srcrist
Copy link

srcrist commented Feb 8, 2023

I was able to reproduce this issue in a testing environment as well, with some additional steps and some other buggy behavior observed.

With a fresh instance on Windows 10, I added a copy of a movie and verified that it was scanned and imported correctly by Jellyfin. Then I duplicated the movie and changed the file name and moved it to a new directory corresponding to the new "version." The second copy was also scanned and imported correctly. I then used the Jellyfin web UI to group the two versions together and it merged correctly and showed two versions correctly on the poster in the UI.

When I then moved one copy from the library storage and re-scanned, it correctly removed the deleted version and showed only one copy in the UI.

The first buggy behavior then surfaced when I added the exact same file and folder BACK to the library storage. After a scan, it put the re-integrated copy back into the listing for the existing movie, and both versions were accessible from the version select dropdown. However, the option to ungroup the two versions was no longer functional. They were seemingly forever grouped together without the ability to split them. There was also no indication on the poster in the UI that there were two grouped items in this listing.

I then removed the clone again, modified the file and folder names again to create another "new" movie/version and added this version to the library storage. This time after a scan Jellyfin added a second copy, as expected, but BOTH listings in the UI displayed the indicator for two versions even though there were only two versions in storage and neither of them had been grouped.

image

When both of these items were grouped using the UI, it grouped both listings together, but now with an indicator that there were three items in the group. When I removed one of the items from the library storage, the poster continued to indicate that there were two items in the group, even though there was only one movie on storage.

image

I archived the data directory with both jellyfin.db and library.db for this small test instance. Feel free to comment if it would be of assistance.

@srcrist
Copy link

srcrist commented Feb 8, 2023

This previous issue is poorly documented, but also appears relevant: #8766

@jellyfin-bot
Copy link
Contributor

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@jellyfin-bot jellyfin-bot added the stale Stale and will be closed if no activity occurs label Jun 9, 2023
@jellyfin-bot jellyfin-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2023
@JPVenson
Copy link
Member

JPVenson commented Jul 3, 2023

go away bot

@dinosmm
Copy link

dinosmm commented Sep 30, 2023

I thought I had an issue with the Merge Versions plugin, but it turns out I am having the exact same issue as described here.

I removed the alternate version of all episodes of a TV show, and now got stuck with the counter showing '2' on every episode, even though there is only one version remaining in the filesystem and everywhere else on the UI.

@boblinthewild
Copy link
Author

[FYI, I'm the OP] It doesn't seem like the developers think this is much of a problem since they let the bug go 'stale.' And perhaps in the grand scheme of things it doesn't jump to the top of the priority list, but to me it represented the sort of thing that a well-performing application should not do. I found a few other similar problems and eventually concluded Jellyfin isn't really ready for prime time.

@JPVenson
Copy link
Member

[FYI, I'm the OP] It doesn't seem like the developers think this is much of a problem since they let the bug go 'stale.' And perhaps in the grand scheme of things it doesn't jump to the top of the priority list, but to me it represented the sort of thing that a well-performing application should not do. I found a few other similar problems and eventually concluded Jellyfin isn't really ready for prime time.

Hey there. I am actively observing this bug. We saw it. However as you said, no dev took it yet and spend his free time to fix it. You are welcome to fix it and contribute. Please report any bug you found here or ask in our chat if you need help with it. We are aware that JF has issues but we already spend much time fixing other stuff and all of us pick what we like. If you dont want Jellyfin anymore there are two mayor alternatives: Plex and Emby you can check out.

@boblinthewild
Copy link
Author

Hey there. I am actively observing this bug. We saw it. However as you said, no dev took it yet and spend his free time to fix it. You are welcome to fix it and contribute. Please report any bug you found here or ask in our chat if you need help with it. We are aware that JF has issues but we already spend much time fixing other stuff and all of us pick what we like. If you dont want Jellyfin anymore there are two mayor alternatives: Plex and Emby you can check out.

Hi, glad to know someone is watching it. I understand the open development model, but decided stuff like this would probably live on for too long in such a model and so abandoned my attempt to use it. I've been using Plex for many years, and was hoping JF might be a good alternative. I ran them in parallel for a couple of months, but unfortunately it didn't pan out.

@dinosmm
Copy link

dinosmm commented Sep 30, 2023

You are welcome to fix it and contribute

I'm nowhere near the skill level required for something like this, but, assuming I could pump up my C# skills, and being unfamiliar with the Jellyfin codebase, is there any indication where I might need to start looking in the code to study this bug and to try to think of a potential solution?

@JPVenson
Copy link
Member

You are welcome to fix it and contribute

I'm nowhere near the skill level required for something like this, but, assuming I could pump up my C# skills, and being unfamiliar with the Jellyfin codebase, is there any indication where I might need to start looking in the code to study this bug and to try to think of a potential solution?

Well thats a bit of a catch22. JF has a pretty ... diverse code base and is not really what i would recommend for C# beginners. But just taken from the top of the list
#10309
might be a good point to investigate and look into.

@theshoeshiner
Copy link

For anyone following this - I just reported a dup of this issue which led me to this. I plan to take a look at the code sometime in the next few days. I haven't specifically worked on the code that manages versions, but I've worked on other pieces of the server codebase so I think it's within the realm of possibility that I can come up with a fix in the next couple weeks.

@thedagnode
Copy link

Hi. I just encountered this same issue myself. I fixed it by lifting out the movie from the library, then rescanned library, pasted the movie back in and rescanned the library. Not sure if that helps with the investigation.

@slmingol
Copy link

Confirming I'm seeing this same bug at the moment as well.
image

@felix920506 felix920506 added the confirmed This issue has been reviewed and confirmed label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This issue has been reviewed and confirmed
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

10 participants