Reduce the amount of allocations in GetWhereClauses #10114
Merged
+163
−235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse 1 StringBuilder to generate multiple clauses instead of creating Lists of strings to join
crobibero
reviewed
Aug 15, 2023
| } | ||
|
|
||
| // Remove last, |
There was a problem hiding this comment.
Suggested change
| // Remove last, | |
| // Remove last "," |
I initially thought this was an unfinished comment
| { | ||
| whereClauses.Add(ratingClauseString + ")"); | ||
| whereClauses.Add(clauseBuilder.Append(')').ToString()); | ||
| clauseBuilder.Length = 0; |
There was a problem hiding this comment.
Shouldn't we clear the clause builder even if length is 0?
There was a problem hiding this comment.
All StringBuilder.Clear() does is setting length to 0
There was a problem hiding this comment.
I would argue the intent with Clear is... Clearer
There was a problem hiding this comment.
I meant to say if the length is 1.. my mistake!
There was a problem hiding this comment.
@cvium I used .length = 0 instead of .clear bc it's done this way in the existing code, but I could change all occurrences if that's preferred.
There was a problem hiding this comment.
@Bond-009 Doesn't really matter to me
cvium
reviewed
Aug 15, 2023
cvium
approved these changes
Aug 20, 2023
Shadowghost
approved these changes
Aug 21, 2023
crobibero
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse 1 StringBuilder to generate multiple clauses instead of creating Lists of strings to join