-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to include resumable items in next up requests #10200
Conversation
Changes in OpenAPI specification found. Expand to see details.What's Changed
|
@@ -86,6 +87,7 @@ public class TvShowsController : BaseJellyfinApiController | |||
[FromQuery] DateTime? nextUpDateCutoff, | |||
[FromQuery] bool enableTotalRecordCount = true, | |||
[FromQuery] bool disableFirstEpisode = false, | |||
[FromQuery] bool enableResumable = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably default this to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I debated that but went with true since it effectively reverts the change that breaks resuming a show when an episode is in progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this shouldn't break much. We should just keep our eyes out for any bug reports during the 10.9 beta cycle and if this causes issue change the default to false
.
Please forgive me if my ignorance is an annoyance and if this is the wrong place to ask: I'm fairly new to using Jellyfin as my home media server. It's been up and running on my Windows PC for just over a month now. But this feature (being able to see resumable items in the Next Up section) is something I greatly desire to enable. What I don't fully understand is how to accomplish enabling it on my Jellyfin server even though this PR appears to suggest that there is a way. How would I go about this? |
Changes
Adds an option to enable resumable items to be included in next up requests. This defaults to true to enable the original behavior of finding the next episode of a series that should be played.
Clients will probably want to add the new request parameter to prevent the duplication on the home screen between next up and continue watching.
Once this is merged I plan to add a new home screen section type that uses this to present a single row for next up + continue watching (as has been requested here).Actually this still won't fully meet the needs for a combined up next + continue watching home screen section since it does not include movies. 馃PR that introduced the initial breakage: #4628
Issues
N/A