Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some incompatible API deprecations #10973

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

nielsvanvelzen
Copy link
Member

Some small changes to make the current Android TV release work with unstable. There might be more, I'll hunt for all of them once the initial release candidate is out.

Changes

  • Add back SupportsContentUploading and SupportsSync to client capabilities, but mark them as nullable and set a default value. Will propagate through the Kotlin SDK to the app with 10.9 so we can remove the properties in 10.10 (as the SDK no longer requires them).
  • In SystemInfo specify some default values so we can remove those properties in the future
  • In SystemInfo remove some types (Architecture and ffmpeglocation) so they generate as simple strings. this is just to reduce the amount of models in the OpenAPI spec, nothing fancy.

Issues

Copy link

github-actions bot commented Feb 6, 2024

Changes in OpenAPI specification found. Expand to see details.

What's Changed


GET /System/Info
Return Type:

Changed response : 200 OK

Information retrieved.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property EncoderLocation (string)

Removed enum values:

openapi-base openapi-changes.md openapi-head NotFound
openapi-base openapi-changes.md openapi-head SetByArgument
openapi-base openapi-changes.md openapi-head Custom
openapi-base openapi-changes.md openapi-head System
openapi-base openapi-changes.md openapi-head Changed property SystemArchitecture (string)

Removed enum values:

openapi-base openapi-changes.md openapi-head X86
openapi-base openapi-changes.md openapi-head X64
openapi-base openapi-changes.md openapi-head Arm
openapi-base openapi-changes.md openapi-head Arm64
openapi-base openapi-changes.md openapi-head Wasm
openapi-base openapi-changes.md openapi-head S390x
openapi-base openapi-changes.md openapi-head LoongArch64
openapi-base openapi-changes.md openapi-head Armv6
openapi-base openapi-changes.md openapi-head Ppc64le

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property EncoderLocation (string)

Removed enum values:

openapi-base openapi-changes.md openapi-head NotFound
openapi-base openapi-changes.md openapi-head SetByArgument
openapi-base openapi-changes.md openapi-head Custom
openapi-base openapi-changes.md openapi-head System
openapi-base openapi-changes.md openapi-head Changed property SystemArchitecture (string)

Removed enum values:

openapi-base openapi-changes.md openapi-head X86
openapi-base openapi-changes.md openapi-head X64
openapi-base openapi-changes.md openapi-head Arm
openapi-base openapi-changes.md openapi-head Arm64
openapi-base openapi-changes.md openapi-head Wasm
openapi-base openapi-changes.md openapi-head S390x
openapi-base openapi-changes.md openapi-head LoongArch64
openapi-base openapi-changes.md openapi-head Armv6
openapi-base openapi-changes.md openapi-head Ppc64le

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property EncoderLocation (string)

Removed enum values:

openapi-base openapi-changes.md openapi-head NotFound
openapi-base openapi-changes.md openapi-head SetByArgument
openapi-base openapi-changes.md openapi-head Custom
openapi-base openapi-changes.md openapi-head System
openapi-base openapi-changes.md openapi-head Changed property SystemArchitecture (string)

Removed enum values:

openapi-base openapi-changes.md openapi-head X86
openapi-base openapi-changes.md openapi-head X64
openapi-base openapi-changes.md openapi-head Arm
openapi-base openapi-changes.md openapi-head Arm64
openapi-base openapi-changes.md openapi-head Wasm
openapi-base openapi-changes.md openapi-head S390x
openapi-base openapi-changes.md openapi-head LoongArch64
openapi-base openapi-changes.md openapi-head Armv6
openapi-base openapi-changes.md openapi-head Ppc64le

POST /Sessions/Capabilities/Full
Request:

Changed content type : application/json

Updated ClientCapabilitiesDto :

  • Added property SupportsContentUploading (boolean)

  • Added property SupportsSync (boolean)

Changed content type : text/json

Updated ClientCapabilitiesDto :

  • Added property SupportsContentUploading (boolean)

  • Added property SupportsSync (boolean)

Changed content type : application/*+json

Updated ClientCapabilitiesDto :

  • Added property SupportsContentUploading (boolean)

  • Added property SupportsSync (boolean)

GET /Devices/Info
Return Type:

Changed response : 200 OK

Device info retrieved.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

GET /Sessions
Return Type:

Changed response : 200 OK

List of sessions returned.

  • Changed content type : application/json

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="CamelCase"

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="PascalCase"

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

GET /Devices
Return Type:

Changed response : 200 OK

Devices retrieved.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property Items (array)

Gets or sets the items.

Changed items (object):

openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Gets or sets the capabilities.

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

POST /Users/{userId}/Authenticate
Return Type:

Changed response : 200 OK

User authenticated.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

POST /Users/AuthenticateByName
Return Type:

Changed response : 200 OK

User authenticated.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

POST /Users/AuthenticateWithQuickConnect
Return Type:

Changed response : 200 OK

User authenticated.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property Capabilities (object)

Updated ClientCapabilities :
openapi-base openapi-changes.md openapi-head Added property SupportsContentUploading (boolean)

openapi-base openapi-changes.md openapi-head Added property SupportsSync (boolean)

@Bond-009 Bond-009 merged commit e50170a into jellyfin:master Feb 7, 2024
23 checks passed
@nielsvanvelzen nielsvanvelzen deleted the api-dep-fixes branch February 7, 2024 18:57
KrzaQ pushed a commit to KrzaQ/jellyfin that referenced this pull request Feb 13, 2024
@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants