Add IListingsManager Service #10981
Add IListingsManager Service #10981
Conversation
barronpm
force-pushed
the
livetv-listingsmanager
branch
from
37cb249
to
3bdaf64
Compare
| /// <param name="validateLogin">A value indicating whether to validate login.</param> | ||
| /// <param name="validateListings">A value indicating whether to validate listings..</param> | ||
| /// <returns>Task.</returns> | ||
| Task<ListingsProviderInfo> SaveListingProvider(ListingsProviderInfo info, bool validateLogin, bool validateListings); |
There was a problem hiding this comment.
Should we append Async to these function names while we're moving them?
There was a problem hiding this comment.
Generally I don't add the Async suffix unless there's a sync overload, but if we want to establish that as a convention we can do that.
There was a problem hiding this comment.
IMO we should, makes it easier to see when a Task isn't properly awaited during code review
There was a problem hiding this comment.
Do analyzers/warnings not cover that already? I would expect build to fail if someone didn't await a method like that
There was a problem hiding this comment.
They should, but in the past things have slipped through
There was a problem hiding this comment.
Alright, in that case I have one more queued PR for this sort of refactoring, then I can make a PR that applies that suffix everywhere in LiveTV
Changes
Adds
IListingsManagerservice to manage listings providers and map their channels to tuner channels