Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: use original title if req.Name is null #11270

Closed
wants to merge 1 commit into from

Conversation

knocte
Copy link

@knocte knocte commented Mar 31, 2024

Changes
Fixes problem about notifications receiving only the description of the movie instead of the title.

Issues
Related: MindFlavor/Jellyfin.Plugins.Telegram#14

Fixes problem about notifications receiving only the description
of the movie instead of the title.

Related: MindFlavor/Jellyfin.Plugins.Telegram#14
@Shadowghost
Copy link
Contributor

Please do not PR against the 10.8 branch, PR against master.

@knocte
Copy link
Author

knocte commented Mar 31, 2024

Please do not PR against the 10.8 branch, PR against master.

Thanks for your reply @Shadowghost , but how can I PR this fix against master if the Emby.Notifications project is not there? Where did it go? I also tried to look for a file or type called NotificationManager, in case it was moved to some other location, but I still don't find it.

@crobibero
Copy link
Member

Emby.Notifications was deprecated in favor of listening to each event. See the webhook plugin for an example as it listens to every event.

https://github.com/jellyfin/jellyfin-plugin-webhook/tree/master/Jellyfin.Plugin.Webhook/Notifiers

@crobibero crobibero closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants