Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw if file was already removed #11286

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Shadowghost
Copy link
Contributor

It is not possible to delete items associated to files because we are throwing before removing the item from the database.

Changes

  • Do not throw if file or folder does not exist

Issues
Fixes #8493

Copy link

github-actions bot commented Apr 3, 2024

Changes in OpenAPI specification found. Expand to see details.

What's Changed


POST /SyncPlay/Queue
Request:

Changed content type : application/json

Updated QueueRequestDto :

  • Changed property Mode (string)

Enum GroupQueueMode.

Changed content type : text/json

Updated QueueRequestDto :

  • Changed property Mode (string)

Enum GroupQueueMode.

Changed content type : application/*+json

Updated QueueRequestDto :

  • Changed property Mode (string)

Enum GroupQueueMode.

POST /SyncPlay/SetRepeatMode
Request:

Changed content type : application/json

Updated SetRepeatModeRequestDto :

  • Changed property Mode (string)

Enum GroupRepeatMode.

Changed content type : text/json

Updated SetRepeatModeRequestDto :

  • Changed property Mode (string)

Enum GroupRepeatMode.

Changed content type : application/*+json

Updated SetRepeatModeRequestDto :

  • Changed property Mode (string)

Enum GroupRepeatMode.

POST /SyncPlay/SetShuffleMode
Request:

Changed content type : application/json

Updated SetShuffleModeRequestDto :

  • Changed property Mode (string)

Enum GroupShuffleMode.

Changed content type : text/json

Updated SetShuffleModeRequestDto :

  • Changed property Mode (string)

Enum GroupShuffleMode.

Changed content type : application/*+json

Updated SetShuffleModeRequestDto :

  • Changed property Mode (string)

Enum GroupShuffleMode.

POST /Items/{itemId}/PlaybackInfo
Request:

Changed content type : application/json

Updated PlaybackInfoDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Changed content type : text/json

Updated PlaybackInfoDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Changed content type : application/*+json

Updated PlaybackInfoDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

POST /LiveStreams/Open
Request:

Changed content type : application/json

Updated OpenLiveStreamDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Changed content type : text/json

Updated OpenLiveStreamDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Changed content type : application/*+json

Updated OpenLiveStreamDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

POST /Sessions/Capabilities/Full
Request:

Changed content type : application/json

Updated ClientCapabilitiesDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Changed content type : text/json

Updated ClientCapabilitiesDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

Changed content type : application/*+json

Updated ClientCapabilitiesDto :

  • Changed property DeviceProfile (object)

A MediaBrowser.Model.Dlna.DeviceProfile represents a set of metadata which determines which content a certain device is able to play.


Specifically, it defines the supported containers and
codecs (video and/or audio, including codec profiles and levels)
the device is able to direct play (without transcoding or remuxing),
as well as which containers/codecs to transcode to in case it isn't.

GET /Sessions
Return Type:

Changed response : 200 OK

List of sessions returned.

  • Changed content type : application/json

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

  • Changed content type : application/json; profile="CamelCase"

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

  • Changed content type : application/json; profile="PascalCase"

Changed items (object):

Class SessionInfo.

openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

POST /Users/AuthenticateByName
Return Type:

Changed response : 200 OK

User authenticated.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

POST /Users/AuthenticateWithQuickConnect
Return Type:

Changed response : 200 OK

User authenticated.

  • Changed content type : application/json

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

  • Changed content type : application/json; profile="CamelCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

  • Changed content type : application/json; profile="PascalCase"

openapi-base openapi-changes.md openapi-head Changed property SessionInfo (object)

Class SessionInfo.

Updated SessionInfo :
openapi-base openapi-changes.md openapi-head Changed property NowPlayingItem (object)

This is strictly used as a data transfer object from the api layer.
This holds information about a BaseItem in a format that is convenient for the client.

@crobibero crobibero added this to In progress in Release 10.9.z via automation Apr 3, 2024
@crobibero crobibero merged commit 134bf7a into jellyfin:master Apr 12, 2024
11 checks passed
Release 10.9.z automation moved this from In progress to Done Apr 12, 2024
@Shadowghost Shadowghost deleted the file-delete-fix branch May 17, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Playlists can't be deleted if they were imported from m3u8 and the origin file is deleted/moved
4 participants