fix: explicitly allow remove root when performing library removal #11352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11269 Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
|
I can confirm that this fixes the issue, but I'm not completely sold on the solution |
I don't like doing it this way either, any better approach? |
This is an alternate approach which is more proper, but changes all parts that uses/overrides the original ValidateChildren method Signed-off-by: gnattu <gnattuoc@me.com>
I pushed an alternate approach, which looks more proper but it changes the signature of |
|
Seems like it's neater and I think, personally, the signature changing is fine. |
Shadowghost
approved these changes
Apr 17, 2024
gnattu
changed the title
Signed-off-by: gnattu <gnattuoc@me.com>
crobibero
approved these changes
Apr 17, 2024
|
My original fix is a complete hack anyway |
cvium
approved these changes
Apr 18, 2024
Bond-009
approved these changes
Apr 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR added a workaround to temporarily mark the UserRoot as non-root during library validation for VirtualFolder removal. This is probably not the best solution but I'd like to see any suggestions.
The RootFolder protection is to not accidentally remove the whole library when the path is temporarily unavailable, and is a valid use case. But when the user explicitly asked for removal, we should not protect it. So perhaps
IsRootcan be renamed to something likeDeleteProtect?Issues
Fixes #11269