Improve audio normalization #11457
Improve audio normalization #11457
Conversation
* Move calculation of LUFS to a scheduled task as it's pretty slow * Correctly calculate album LUFS * Don't try to convert replaygain tags to LUFS values
|
I've tested this with @Bond-009's help and it seems to be working (on Windows at least). We found one bug related to albums with only a single track but that is now fixed. I've confirmed this works properly and already integrated the changes into Finamp without issues 😁 |
Emby.Server.Implementations/ScheduledTasks/Tasks/AudioNormalizationPostScanTask.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // Album gain | ||
| var albums = _libraryManager.GetItemList(new InternalItemsQuery |
There was a problem hiding this comment.
I'm never a fan of pulling all of an item type from the database.
There was a problem hiding this comment.
Yeah, but this can be changed when progress reporting is added
Emby.Server.Implementations/ScheduledTasks/Tasks/AudioNormalizationPostScanTask.cs
Outdated
Show resolved
Hide resolved
Emby.Server.Implementations/ScheduledTasks/Tasks/AudioNormalizationPostScanTask.cs
Outdated
Show resolved
Hide resolved
| Recursive = true | ||
| }); | ||
|
|
||
| foreach (var a in albums) |
There was a problem hiding this comment.
Should add a try..catch so we don't stop processing on first (or any) failure
There was a problem hiding this comment.
There is a try catch inside of CalculateLUFSAsync where I'd expect these failures to take place.
Seems unlikely anything would go wrong here, and it it does (like failing to create the concat file) it would likely happen to the other items as well
TODO: