Fix broken hardware encoder and filter for trickplay #11506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardware processing pipeline never worked for trickplay, because the required encoder was not added to the validator and the software encoder is always passed to the ProcessingFilter builder, which always returns the software filter+encoder. Signed-off-by: gnattu <gnattuoc@me.com>
gnattu
added
bug
Shadowghost
reviewed
May 7, 2024
|
These additional platforms should go with 10.10 in my opinion, they will require additional code to work. |
nyanmisaka
approved these changes
May 7, 2024
nielsvanvelzen
removed
the
release critical
Shadowghost
approved these changes
May 7, 2024
Bond-009
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardware processing pipeline never worked for trickplay, because the required encoder was not added to the validator and the software encoder is always passed to the ProcessingFilter builder, which returns the software filter+encoder.
Changes
Issues