Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set cast receivers during migration #11516

Merged
merged 1 commit into from
May 10, 2024

Conversation

crobibero
Copy link
Member

Might prevent #11502 though I haven't been able to reproduce the issue

@crobibero crobibero added this to In progress in Release 10.9.z via automation May 9, 2024
@gnattu
Copy link
Member

gnattu commented May 9, 2024

A dirtier but maybe more reliable workaround might be just set this as the default value, instead of setting it during migration. I think it is very likely that clients can overwrite this during configuration update and accidentally reset it to the default (empty).

@crobibero
Copy link
Member Author

A dirtier but maybe more reliable workaround might be just set this as the default value, instead of setting it during migration. I think it is very likely that clients can overwrite this during configuration update and accidentally reset it to the default (empty).

This would prevent a user from completely removing reference to our cast receivers

@gnattu
Copy link
Member

gnattu commented May 9, 2024

A dirtier but maybe more reliable workaround might be just set this as the default value, instead of setting it during migration. I think it is very likely that clients can overwrite this during configuration update and accidentally reset it to the default (empty).

This would prevent a user from completely removing reference to our cast receivers

Would adding an option to the web like "reset cast devices" which restore the default receivers list on the web be a good workaround then? Such accidents do occur and the user might be unaware of the actual reason, and only want to make it working again. Manually edit the xml file in this case is very undesirable.

@crobibero crobibero merged commit 5d2a1da into jellyfin:master May 10, 2024
11 checks passed
Release 10.9.z automation moved this from In progress to Done May 10, 2024
@crobibero crobibero deleted the cast-receivers branch May 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants