Recalculate trickplay image height for anamorphic videos #11798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gnattu <gnattuoc@me.com>
Shadowghost
approved these changes
May 23, 2024
nyanmisaka
approved these changes
May 23, 2024
crobibero
reviewed
May 23, 2024
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
crobibero
approved these changes
May 23, 2024
Bond-009
approved these changes
May 24, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
May 25, 2024
Recalculate trickplay image height for anamorphic videos Original-merge: d9232e0 Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might still be not exactly accurate but should not be tell from human eyes on most videos.
The most problematic ones would be the 3D Videos where the aspect ratio stored in the container might be per eye instead of per frame, which will lead to an incorrect height being calculated. But we can really do little about that for current pipeline.
Changes
Issues
Fixes #11785