Move to netcore3.0 #1884
Merged
Move to netcore3.0 #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EraYaN
approved these changes
Oct 11, 2019
JustAMan
reviewed
Oct 15, 2019
There was a problem hiding this comment.
Changes look fine, but please have a look at failing CI - we need to either fix the failure or have an explanation that would result in understanding that it's safe to ignore that failure.
@EraYaN maybe you can also have a look at CI failures and state if it's safe to ignore them to merge.
|
I think that one can be ignored. The resolution scope might not be compatible between 2.2 and 3.0. Not sure where |
JustAMan
approved these changes
Oct 15, 2019
|
cc @joshuaboniface we may need to update build scripts now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.