Fix parsing of certain names and adds a default season if no season was found #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 10, 2019 13:22
This should in the future help to detect working and non working name matchings
Add another parser case and we now allow parsing of seasonless series which hopefully should cover more cases of directory structure
JustAMan
reviewed
Nov 1, 2019
|
@joshuaboniface maybe we can backport this one? |
this definitely should be part of next release (10.4.2), so I added the label |
|
The latest push to this branch fixes the comments from @JustAMan. |
JustAMan
approved these changes
Nov 7, 2019
dkanada
approved these changes
Nov 7, 2019
joshuaboniface
changed the title
|
Cherry-picked into 10.4.2. |
joshuaboniface
pushed a commit
that referenced
this pull request
Nov 24, 2019
[Draft][Help wanted] Fix parsing of certain names and adds a default season if no season was found (cherry picked from commit 61b9b40) Signed-off-by: Joshua Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixed some parsing errors for files found in the anime community.
This pull request includes the test cases from my previous pull request (#1877).
I tested this patch and it now parses quite a few more files on my system, however, the tests do not seem to work. If somebody could help out with figuring out why the test cases do not work, I would be very happy.