Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullable reference types for Jellyfin.Server #1942

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Enable nullable reference types for Jellyfin.Server #1942

merged 2 commits into from
Nov 27, 2019

Conversation

Bond-009
Copy link
Member

No description provided.

dkanada
dkanada reviewed Oct 29, 2019
View reviewed changes
Jellyfin.Server/Program.cs Outdated Show resolved Hide resolved
Jellyfin.Server/Program.cs Show resolved Hide resolved
@Bond-009 @dkanada
Update Jellyfin.Server/Program.cs
1258a37 
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
JustAMan
JustAMan reviewed Nov 22, 2019
View reviewed changes
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but why do you want to make certain properties nullable? What is the reasoning?

Jellyfin.Server/Program.cs Show resolved Hide resolved
@JustAMan JustAMan mentioned this pull request Nov 22, 2019
Closed
@Bond-009
Copy link
Member Author

@JustAMan they were by default, by enabling nullable reference types you have to explicitly make them nullable.
Ref: https://devblogs.microsoft.com/dotnet/nullable-reference-types-in-csharp/

@Bond-009 Bond-009 mentioned this pull request Nov 25, 2019
Merged
@JustAMan JustAMan merged commit c45d54e into jellyfin:master Nov 27, 2019
@Bond-009 Bond-009 deleted the nullable branch November 27, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkanada dkanada dkanada left review comments

@cvium cvium cvium approved these changes

@JustAMan JustAMan JustAMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bond-009 @cvium @JustAMan @dkanada