Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full Raspberry Pi hardware accelerated decoding support #2058

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Add full Raspberry Pi hardware accelerated decoding support #2058

merged 1 commit into from
Nov 29, 2019

Conversation

ferferga
Copy link
Member

Although support to the Broadcom Multimedia Abstraction Layer has been added to jellyfin-ffmpeg and h264_mmal was already handled in the logic of the server, it seems that it wasn't registered as a valid one in the validator and it's simply skipped.

This quick PR aims to add full support for all the hardware accelerated codecs that the Pi and MMAL-capable devices provides. Although it can be instantly merged, it should be considered as a WIP, as I'm still testing in my environment all the filetypes and bitrates possible.

Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JustAMan
Copy link
Contributor

@ferferga I noted that your PR title says "decoding support" but you were actually adding encoders, so I tweaked the title. Please check I did so correctly.

@JustAMan JustAMan changed the title Add full Raspberry Pi hardware accelerated decoding support Add full Raspberry Pi hardware accelerated encoding support Nov 27, 2019
@ferferga
Copy link
Member Author

@JustAMan Hmm, that's not what I meant to do then, as mmal is a HW decoder only (OMX is the encoder in Pi's case).

I added the missing decoders to the GetHardwareAcceleratedVideoDecoder and requiredDecoders strings, just in line where other HW decoders are. Although the EncodingHelper and EncodingValidator names are a bit misleading, it seems to me that it's where all the logic for both decoding and encoding happens.

Correct me if I'm wrong, because otherwise I'm completely implementing this the other way around.

@JustAMan
Copy link
Contributor

Hmm, I read the code better and I now think you're indeed specifying a decoder.
I just never saw before that -codec could be used to specify a decoder. Excuse me, I "fixed" the title back.

@JustAMan JustAMan changed the title Add full Raspberry Pi hardware accelerated encoding support Add full Raspberry Pi hardware accelerated decoding support Nov 27, 2019
@ferferga
Copy link
Member Author

@JustAMan No problem! 😁👍

@JustAMan JustAMan merged commit 32519a5 into jellyfin:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants